Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OtlpMetricsExporter should not reference BatchExportProcessorOptions<Activity> #2246

Closed
pellared opened this issue Aug 11, 2021 · 2 comments
Closed

OtlpMetricsExporter should not reference BatchExportProcessorOptions<Activity> #2246

pellared opened this issue Aug 11, 2021 · 2 comments
Labels
metrics Metrics signal related Stale Issues and pull requests which have been flagged for closing due to inactivity

Comments

@pellared
Copy link
Member

Currently the OtlpMetricsExporter has a OtlpExporterOptions field which contains a BatchExportProcessorOptions<Activity> field.

OtlpMetricsExporter should not reference BatchExportProcessorOptions<Activity> as it is intended for tracing.

It can be fixed e.g. by adding another generic parameter to BaseOtlpExporter for the option type could differ for OtlpMetricsExporter and OtlpTraceExporter.

Found when working on #2219
@pellared pellared changed the title OtlpMetricsExporter should not reference BatchExportProcessorOptions<Activity> OtlpMetricsExporter should not reference BatchExportProcessorOptions<Activity> Aug 11, 2021
@pellared pellared mentioned this issue Aug 11, 2021
Merged
@cijothomas cijothomas added the metrics Metrics signal related label Nov 24, 2021
@github-actions GitHub Actions
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 22, 2024
@vishweshbankwar
Copy link
Member

#4527 will handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
metrics Metrics signal related Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pellared @cijothomas @vishweshbankwar