Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit and functional tests for propagation in case of legacy Activities #2700

Closed
vishweshbankwar opened this issue Nov 29, 2021 · 0 comments · Fixed by #2704
Closed
Labels
enhancement New feature or request

Comments

@vishweshbankwar
Copy link
Member

vishweshbankwar commented Nov 29, 2021

Related to #2659.

In case of legacy activities (i.e. new Activity()), we run the sampler after the activity is started. When the sampler runs it updates the ActivityTraceFlags property based on the sampling result. However, updating the trace flags on activity does not get reflected on Id if the Id was accessed before sampler runs. This results is incorrect propagation when the propagator uses Id property to set the traceparent header.

@vishweshbankwar vishweshbankwar added the enhancement New feature or request label Nov 29, 2021
@vishweshbankwar vishweshbankwar changed the title Improve unit and functional tests for propagators in case of legacy Activities Improve unit and functional tests for propagation in case of legacy Activities Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant