Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientInstrumentationOptions doesn't support IDeferredTracerProviderBuilder #3050

Closed
tillig opened this issue Mar 15, 2022 · 0 comments · Fixed by #3051
Closed

HttpClientInstrumentationOptions doesn't support IDeferredTracerProviderBuilder #3050

tillig opened this issue Mar 15, 2022 · 0 comments · Fixed by #3051
Labels
bug Something isn't working

Comments

@tillig
Copy link
Contributor

tillig commented Mar 15, 2022

Bug Report

The AddAspNetCoreInstrumentation extension shows what it looks like to support IDeferredTracerProviderBuilder so it can take advantage of the DI container and registered Options<AspNetCoreInstrumentationOptions>.

The corresponding AddHttpClientInstrumentation extension does not currently support IDeferredTracerProviderBuilder so there's no way to use Options<T> to configure things like enrichers.

(Unclear if this is a bug or an enhancement request so I just picked bug. I'm going to throw a PR in to fix this in a minute anyway.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AddHttpClientInstrumentation uses Options<T>. tillig/opentelemetry-dotnet
1 participant
@tillig