SamplingParameters does not include the activity source

[WeihanLi]

Feature Request

Include the activity source into the SamplingParameters,

Is your feature request related to a problem?

We want to implement a TraceIdRatioBasedSampler based sampler, we want to use a different ratio for different activity sources, currently, the SamplingParameters does not have an ActivitySource, while there's ActivitySource in the ActivityCreationOptions which be used to determine the ActivitySamplingResult

https://github.com/dotnet/runtime/blob/v6.0.0/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivityCreationOptions.cs

https://github.com/dotnet/runtime/blob/v6.0.0/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/ActivitySamplingResult.cs

Describe the solution you'd like:

Maybe we could add the ActivitySource to the SamplingParameters, so that we could use different sampler for different activity source

[vishweshbankwar]

@WeihanLi This is by design as per specification

[WeihanLi]

@vishweshbankwar thanks very much, is there any workaround solution to implement different sampling logic according to the activity source?

[cijothomas]

@vishweshbankwar thanks very much, is there any workaround solution to implement different sampling logic according to the activity source?

https://github.com/open-telemetry/opentelemetry-specification/pull/1942/files

I think its best asked in spec, as this was added then reverted in spec itself.

You may multiple TracerProviders with diff. sampler, and have them enble diff. ActivitySources as a hacky workaround.