Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Deserialize GrpcStatusDetailsHeader to Retrieve Grpc Retry Delay #5980

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes Part of #5730
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Introduces functionality to deserialize the Google.Rpc.Status proto from the GrpcStatusDetailsHeader(grpc-status-details-bin) string and extract retry delay information from the Google.Rpc.RetryInfo message embedded in the Details field.

Deserialized proto: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/google/rpc/status.proto

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner November 15, 2024 23:20
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (2ae01a7) to head (54fdd4a).

Files with missing lines Patch % Lines
...tation/ExportClient/Grpc/GrpcStatusDeserializer.cs 86.20% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5980      +/-   ##
==========================================
+ Coverage   84.50%   84.62%   +0.11%     
==========================================
  Files         271      272       +1     
  Lines       12355    12471     +116     
==========================================
+ Hits        10441    10553     +112     
- Misses       1914     1918       +4     
Flag Coverage Δ
unittests-Project-Experimental 84.56% <86.20%> (+0.23%) ⬆️
unittests-Project-Stable 84.60% <86.20%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tation/ExportClient/Grpc/GrpcStatusDeserializer.cs 86.20% <86.20%> (ø)

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant