Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpentelemetryReq: log when path_params not set and continue #351

Open
derekkraan opened this issue Jul 16, 2024 · 0 comments · May be fixed by #375
Open

OpentelemetryReq: log when path_params not set and continue #351

derekkraan opened this issue Jul 16, 2024 · 0 comments · May be fixed by #375
Labels
enhancement New feature or request

Comments

@derekkraan
Copy link
Contributor

Continuing from a discussion I had on Slack with @bryannaegele.

This pertains to the behaviour present in the OpentelemetryReq library, where the request can be halted under the following circumstances:

  • :no_path_params option is unset
  • path_params has not been used in the Req.Request

The main issue from my point of view is that the instrumentation is changing application behaviour by halting the request here.

Describe the solution you'd like

  • remove the :no_path_params option in favour of the branch no_path_params: true.
  • In other words, fall back from path_params HTTP GET /foo/:bar to simply HTTP GET
  • Log (Bryan suggested to info, I'd suggest debug) when this fallback occurs.
  • Never halt a request.

Describe alternatives you've considered
None

Additional context
None

@derekkraan derekkraan added the enhancement New feature or request label Jul 16, 2024
@bryannaegele bryannaegele linked a pull request Sep 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant