Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set is_recording to false in the span context #118

Closed
tsloughter opened this issue Oct 6, 2020 · 1 comment
Closed

Set is_recording to false in the span context #118

tsloughter opened this issue Oct 6, 2020 · 1 comment
Labels
enhancement New feature or request scope-api scope-sdk
Milestone
GA

Comments

@tsloughter
Copy link
Member

Added to the spec in open-telemetry/opentelemetry-specification#1011 which should be merged soon.

In our case it means updating the span context stored in the context when End is called, which is nice since it'll make future calls of any functions to update the span in ets (which will fail since the span has been end'ed and moved to the export table) will short circuit on the span context is_recording being false.
@tsloughter tsloughter added this to the GA milestone Oct 6, 2020
@tsloughter
Copy link
Member Author

Closed by #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request scope-api scope-sdk
Projects
None yet
Milestone
GA
Development

No branches or pull requests
1 participant
@tsloughter