Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to support integration tests #160

Closed
MrAlias opened this issue Jul 29, 2020 · 1 comment · Fixed by #191
Closed

Update CI to support integration tests #160

MrAlias opened this issue Jul 29, 2020 · 1 comment · Fixed by #191
Assignees
Labels
area: instrumentation Related to an instrumentation package
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 29, 2020

In both the mongo and cassandra instrumentation the testing requires and actual database:

Our current CI system does not stand any of these up so the testing is currently disabled. We should automate some form of testing to work with the CI system that supports these tests.

@MrAlias MrAlias added the area: instrumentation Related to an instrumentation package label Jul 29, 2020
@reggiemcdonald
Copy link
Contributor

I would be interested in getting the tests running for mongo and gocql!

plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* Add Stackdriver Trace exporter for trace.

TODOs for future work is:

* to replace bundler.Bundler

* to add proper tests for the exporter

* to move the exporter to proper repository once it will be created.

* Change to use functions for the exporter initialization instead of
passing option struct directly.
This fix is aliging the same fix for Jaeger (#146, #161)

* Change Option struct to be function type

* Change the original Option struct to be private

* Add line comments to maxMessageEventsPerSpan to leave it for future implementation

* Fix unnessesary expressions specified by `make precommit`

Left errors by `make precommit` in experimental/bridge/opentracing.

* Ran make precommit

* Add new line at EOF

* WIP: Start implementing BatchSpanExporter interfaces

* Change to use RegisterSpanProcessor to register bsp

* Change function names to fit current implementation of sdk

* Removed google.golang.org/api/support/bundler and implement ssp and bsp

* Change spanProcessor as a member of Exporter.

* Fix option names used for BatchSpanProcessor initialization.

* Change Exporter.Shutdown just to unregister spanProcessor.

* Removed copyright statements of OpenCensus.

* Fix small typo and EOF new line

* Fix interfaces of ExportSpan/ExportSpans to meet SpanSyncer/SpanBatcher

* Change to follow context.Context passed in ExportSpan/ExportSpans

* Fix Stackdriver Exporter to hold sync.Once to lock when it is registered and
unregistered.
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants