Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the mock tracer into the otel-go's mock tracer. #31

Closed
krnowak opened this issue May 5, 2020 · 1 comment · Fixed by #414
Closed

Merge the mock tracer into the otel-go's mock tracer. #31

krnowak opened this issue May 5, 2020 · 1 comment · Fixed by #414
Assignees
@matej-g
Labels
help wanted Extra attention is needed
Milestone
RC1

Comments

@krnowak
Copy link
Member

krnowak commented May 5, 2020

The mock tracer in internal/trace is a modified copy of the mock tracer in otel-go. When we decide that our copy of mock tracer meets the needs of the instrumentation testing code (so the mock tracer stabilized) then it would be good to reduce the code duplication and bring the changes back to otel-go.
@MrAlias MrAlias added the help wanted Extra attention is needed label Jun 18, 2020
@MrAlias MrAlias added this to the RC1 milestone Sep 3, 2020
@matej-g matej-g mentioned this issue Oct 6, 2020
Closed
@matej-g
Copy link
Contributor

matej-g commented Oct 9, 2020 •
edited
Loading

Would take this together with #385

@matej-g matej-g mentioned this issue Oct 19, 2020
Merged
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@thinkerou @rghetia
update (#31)
8c47aeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matej-g matej-g

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
RC1
3 participants
@krnowak @MrAlias @matej-g