Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update span status code setting in gRPC interceptor to reflect changes in the spec #387

Closed
matej-g opened this issue Oct 7, 2020 · 2 comments
Labels
area: instrumentation Related to an instrumentation package
Milestone

Comments

@matej-g
Copy link
Contributor

matej-g commented Oct 7, 2020

It seems after open-telemetry/opentelemetry-specification#966, and also taking into consideration changes made to codes pkg (open-telemetry/opentelemetry-go#1214), the span error codes are no longer 1:1 with gRPC errors.

When setting a span status based off the Status from grpc in otelgrpc/interceptor.go, this change should be taken into consideration.

Possibly could also resolve #295

@MrAlias MrAlias added area: instrumentation Related to an instrumentation package priority:p1 labels Oct 7, 2020
@MrAlias MrAlias added this to the RC1 milestone Oct 7, 2020
@Aneurysm9
Copy link
Member

#391 addresses this to some respect in that it needed to update the span status codes to codes.Error to account for open-telemetry/opentelemetry-go#1214. @matej-g is there anything else you feel needs to be done for this issue, or can it be closed with the v0.13.0 release?

@matej-g
Copy link
Contributor Author

matej-g commented Oct 13, 2020

I think the release addresses the issue completely, this can be closed, I believe together with #295.

plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package
Projects
None yet
Development

No branches or pull requests

3 participants