otelmemcache: Simplify config and span status setting #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Service name no longer needed - No need to keep config inside of client any longer
- Set status only in case of error
matej-g
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
matej-g
changed the title
matej-g
force-pushed
the
otelmemcache-fix-status-code-attributes
branch
from
cbcfc31 to
6bc4032
Compare
matej-g
changed the title
dashpole
reviewed
Dec 8, 2020
| // Option is used to configure the client. | ||
| type Option func(*config) | ||
| type Option oteltrace.TracerProvider |
There was a problem hiding this comment.
We should probably stick with a generic Option type like we had before. Even though we only have a single option now, we may want to add others in the future.
There was a problem hiding this comment.
Yes, now I see this could potentially be a breaking change, good point 👍. I'll keep the type as it was.
jmacd
approved these changes
Dec 11, 2020
XSAM
approved these changes
Dec 26, 2020
XSAM
reviewed
Dec 26, 2020
|
|
||
| ### Removed | ||
|
|
||
| - Remove service name from `otelmemcache` configuration and span attributes. (#477) |
There was a problem hiding this comment.
Suggested change
| - Remove service name from `otelmemcache` configuration and span attributes. (#477) | |
| - Remove service name from `otelmemcache` configuration and span attributes. (#477) | |
nit
This was referenced Mar 7, 2021
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of things with
otelmemcacheinstrumentation that should be adjusted: to make it adhere to the specification on one hand, and to remove some unnecessary parts on the other. Specifically:Resolves #408