Fix goroutine leak in gRPC StreamClientInterceptor #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
XSAM
changed the title
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 55 55
Lines 2597 2602 +5
=====================================
+ Hits 2024 2029 +5
Misses 443 443
Partials 130 130
|
denis-tingaikin
suggested changes
Feb 17, 2021
XSAM
force-pushed
the
grpc-leak-goroutine
branch
from
c659687 to
05247b9
Compare
MrAlias
approved these changes
Feb 17, 2021
Aneurysm9
approved these changes
Feb 17, 2021
dashpole
approved these changes
Feb 18, 2021
This was referenced Mar 7, 2021
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501