Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation for github.com/astaxie/beego #82

Closed
4 tasks done
MrAlias opened this issue Jun 18, 2020 · 4 comments
Closed
4 tasks done

Add instrumentation for github.com/astaxie/beego #82

MrAlias opened this issue Jun 18, 2020 · 4 comments
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
untracked

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jun 18, 2020 •
edited
Loading

https://github.com/astaxie/beego

Tasks

  • code complete with tests passing
  • Dockerfile with example app showing instrumentation
  • documentation updated
  • instrumentation added to the opentelemetry registry

Prior Art
@MrAlias MrAlias added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed area: instrumentation Related to an instrumentation package labels Jun 18, 2020
@reggiemcdonald
Copy link
Contributor

reggiemcdonald commented Aug 7, 2020 •
edited
Loading

Could the beego instrumentation leverage the net/http instrumentation that was merged in this week?

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 7, 2020

Could the beego instrumentation leverage the net/http instrumentation that was merged in this week?

That seems to be what the OpenTracing project did: https://github.com/opentracing-contrib/beego/blob/master/middleware.go

Sounds like a good approach to me. 👍

@reggiemcdonald reggiemcdonald mentioned this issue Aug 7, 2020
Merged
2 tasks
@reggiemcdonald
Copy link
Contributor

@MrAlias go ahead and close this one! opentelemetry.io has been updated with a link to the beego integration

@MrAlias
Copy link
Contributor Author

MrAlias commented Aug 20, 2020

Awesome @reggiemcdonald! Thanks for all the help 🥇

@MrAlias MrAlias closed this as completed Aug 20, 2020
plantfansam referenced this issue in plantfansam/opentelemetry-go-contrib Mar 18, 2022
@djosephsen @rghetia
add tests for api/trace/current.go (#82)
8e7e1fd 
* add tests for api/trace/current.go

* add interface validaion for type: mockSpan

* rework for exported NoopSpan and ditch useless tabletest for TestSetCurrentSpan()
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
3 participants
@pellared @MrAlias @reggiemcdonald