-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Attributes and Labels #1069
Comments
Since we are not afraid of renaming packages and moving types, have we considered a package name like "attr"? |
My hope was to unify on the term It is important that this work does not impact the compatibility of the project. That means that the Spant field will likely need to remain being named |
open-telemetry/opentelemetry-specification#948 This is likely going to be the top issue at the next Specification SIG meeting. |
Specification issue is being tracked here now: open-telemetry/opentelemetry-specification#1113 |
Given the |
Let's rename the |
Currently
Attribute
s in the tracing portion of this code is synonymous withlabel.KeyValue
. This duplicate naming (attribute and label) will lead to confusion for new (and likely existing) users. This duplication comes from the specification itself unfortunately. Attributes are used in the tracing and resource specification (and have been unified in the "common" part of the specification) and labels are used in the metric specification. There was a previous attempt to resolve this difference in the specification, but it did not produce a resolution.Can we do better in this repository?
The text was updated successfully, but these errors were encountered: