Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update span limits to conform with OpenTelemetry specification #1535

Merged
merged 12 commits into from
Feb 18, 2021

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Feb 13, 2021

From the specfication:

AttributeCountLimit (Default=128) - Maximum allowed span attribute count;
EventCountLimit (Default=128) - Maximum allowed span event count;
LinkCountLimit (Default=128) - Maximum allowed span link count;
AttributePerEventCountLimit (Default=128) - Maximum allowed attribute per span event count;
AttributePerLinkCountLimit (Default=128) - Maximum allowed attribute per span link count;

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #1535 (d8a14f4) into main (ecf65d7) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #1535   +/-   ##
=====================================
  Coverage   78.0%   78.0%           
=====================================
  Files        127     127           
  Lines       6582    6599   +17     
=====================================
+ Hits        5136    5153   +17     
  Misses      1201    1201           
  Partials     245     245           
Impacted Files Coverage Δ
sdk/trace/provider.go 95.0% <100.0%> (+0.4%) ⬆️
sdk/trace/span.go 91.0% <100.0%> (+0.3%) ⬆️

@XSAM XSAM marked this pull request as ready for review February 14, 2021 13:00
sdk/trace/config.go Outdated Show resolved Hide resolved
sdk/trace/config.go Outdated Show resolved Hide resolved
sdk/trace/config.go Outdated Show resolved Hide resolved
sdk/trace/config.go Outdated Show resolved Hide resolved
sdk/trace/config.go Outdated Show resolved Hide resolved
sdk/trace/span.go Show resolved Hide resolved
sdk/trace/span.go Outdated Show resolved Hide resolved
sdk/trace/trace_test.go Outdated Show resolved Hide resolved
sdk/trace/tracer.go Outdated Show resolved Hide resolved
sdk/trace/trace_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the RC1 milestone Feb 18, 2021
@MrAlias MrAlias merged commit 298c5a1 into open-telemetry:main Feb 18, 2021
@XSAM XSAM deleted the span-limit branch February 19, 2021 03:18
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants