-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update span limits to conform with OpenTelemetry specification #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1535 +/- ##
=====================================
Coverage 78.0% 78.0%
=====================================
Files 127 127
Lines 6582 6599 +17
=====================================
+ Hits 5136 5153 +17
Misses 1201 1201
Partials 245 245
|
XSAM
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
February 14, 2021 13:00
Aneurysm9
approved these changes
Feb 17, 2021
MrAlias
reviewed
Feb 17, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dashpole
approved these changes
Feb 18, 2021
MrAlias
approved these changes
Feb 18, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the specfication: