Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus counters should have a _total suffix appended. #3359

Closed
dashpole opened this issue Oct 18, 2022 · 0 comments · Fixed by #3360
Closed

Prometheus counters should have a _total suffix appended. #3359

dashpole opened this issue Oct 18, 2022 · 0 comments · Fixed by #3360
Assignees
@dashpole
Labels
bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package
Milestone
Metric v0.33.0

Comments

@dashpole
Copy link
Contributor

Discovered in #3352 (comment).

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#sums-1

Monotonic Sum metric points MUST have _total added as a suffix to the metric name.

Our current counter.txt testcase demonstrates that the _total suffix is not being correctly appended.
@dashpole dashpole added bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package labels Oct 18, 2022
@dashpole dashpole mentioned this issue Oct 18, 2022
Merged
@dashpole dashpole self-assigned this Oct 18, 2022
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Oct 18, 2022
@dashpole dashpole mentioned this issue Oct 18, 2022
Merged
Repository owner moved this from Todo to Done in Go: Metric SDK (Beta) Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package
Projects
No open projects
Go: Metric SDK (Beta)
Status: Done
Milestone
Metric v0.33.0
Development

Successfully merging a pull request may close this issue.

Add _total suffixes to prometheus counters dashpole/opentelemetry-go
2 participants
@dashpole @MrAlias