-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrument provider caching #3527
Comments
Hi @MrAlias - I would like to take this issue on! I forked the repo but have noticed that there has been some restructuring done to the metric/sdk module since this issue was created. In particular, it appears there is a Is the issue referring to something else? Or does it need to be marked as closed/complete? |
@Omkar-Waingankar I would recommend holding of on this issue until we have a more stable SDK. There are still incoming changes in the instrument provider that would affect any caching at this level. |
Split from #3245
Create a cache for the
instProvider
type and use it for this method:opentelemetry-go/sdk/metric/instrument_provider.go
Line 37 in 4146bd1
This will prevent the need for duplicate aggregator lookups when a user asks for the exact same instrument multiple times.
The text was updated successfully, but these errors were encountered: