Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify compliant metric SDK specification implementation: Defaults and configuration #3669

Closed
2 tasks done
Tracked by #3674
MrAlias opened this issue Feb 3, 2023 · 3 comments
Closed
2 tasks done
Tracked by #3674
Assignees
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 3, 2023

  • Identify all the normative requirements, recommendations, and options the specification defines as comments to this issue
  • Ensure the current metric SDK implementation is compliant with these normative requirements, recommendations, and options in those comments.
@MrAlias MrAlias converted this from a draft issue Feb 3, 2023
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Feb 3, 2023
@pellared pellared moved this from Todo to In Progress in Go: Metric SDK (GA) Jun 2, 2023
@pellared pellared self-assigned this Jun 2, 2023
@pellared
Copy link
Member

pellared commented Jun 2, 2023

The SDK MUST provide configuration according to the SDK environment variables specification.

From https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/configuration/sdk-environment-variables.md:

SDKs MAY choose to allow configuration via the environment variables in this specification, but are not required to.

Therefore, the most important thing is to check if there are no environment variable is marked as stable which is not defined in https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/configuration/sdk-environment-variables.md and if the defined env vars are implemented as specified.

Following metrics related env vars are defined:

I do not find any env vars that would make https://pkg.go.dev/go.opentelemetry.io/otel/sdk/metric@v0.39.0 not compliant with the specification.

@pellared
Copy link
Member

pellared commented Jun 2, 2023

It looks like we comply with this fragment of the specification.

@MrAlias Can you please double-check and close if you agree with my verification?

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 2, 2023

LGTM

@MrAlias MrAlias closed this as completed Jun 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Metric SDK (GA) Jun 2, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

No branches or pull requests

2 participants