-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify compliant metric SDK specification implementation: Numerical limits handling #3670
Comments
The specification only calls out |
Exploratory tested with NaN, Inf+, Inf-. Results: #4209. Everything works as expected. |
This is explicitly not normative. |
This is not normative. However, there is a requirement that "OpenTelemetry implementations MUST NOT throw unhandled exceptions at run time." that needs to be checked. Integer overflows are not causing runtime panic at runtime. The value is simply overflown. Reference: https://go.dev/ref/spec#Integer_overflow |
It looks like we comply with this fragment of the specification. @MrAlias Can you please double-check and close if you agree with my verification? |
LGTM |
The text was updated successfully, but these errors were encountered: