Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose opencensus #4729

Closed
pellared opened this issue Nov 21, 2023 · 2 comments
Closed

Decompose opencensus #4729

pellared opened this issue Nov 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Milestone

Comments

@pellared
Copy link
Member

I am not sure if we want the "Trace Bridge" and "OpenCensus-Metrics-Shim" to be contained in a single Go module.
The components have different dependencies (mainly OTel Trace API vs OTel Metrics SDK).

Maybe we should provide opencensustrace (or octrace) and (or ocmetric) Go modules in subdirectories? I am leaning towards oc* package naming as opensensus will be already in the import path. Therefore, I propose go.opentelemetry.io/otel/bridge/opencensus/octrace and go.opentelemetry.io/otel/bridge/opencensus/ocmetric.

The current approach seems compliant with the OTel Specification. However, it does not follow the way we structure Go modules.

@dashpole
Copy link
Contributor

Some counter points, although i'm not entirely against the idea:

Curious what others think.

@MrAlias
Copy link
Contributor

MrAlias commented Nov 30, 2023

SIG meeting notes:

  • There doesn't seem to be a strong desire for this refactor
  • There isn't a strong opposition to the change either
  • There are already about ~20 public packages that depend on this module structure: https://pkg.go.dev/go.opentelemetry.io/otel/bridge/opencensus?tab=importedby
    • This kind of a breaking change will affect these 20 known projects adversely
  • This will require 3 releases to complete and then stabilize the OC bridge
    1. Split into new modules and deprecate the old
    2. Remove the old module
    3. Make an RC
  • Given the lack of motivation by most contributors for this change (and slight apprehension). There needs to be a leader with a strong desire to make this change that will put in the effort to achieve this.

@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Projects
No open projects
Development

No branches or pull requests

4 participants