bridge/opentracing: propagated baggage item key is canonicalized #4799
Labels
area:baggage
Part of OpenTelemetry baggage
bug
Something isn't working
pkg:bridges
Related to a bridge package
Milestone
Description
When a baggage item key is added to a bridge span, they shouldn't be canonicalized by
http.CanonicalHeaderKey
opentelemetry-go/bridge/opentracing/bridge.go
Lines 76 to 88 in 1cfd83a
Additional Info
Seems like this was added in the initial opentracing bridge implementation in https://www.github.com/open-telemetry/opentelemetry-go/issues/98
opentelemetry-java
does not canonicalize the keys: https://github.com/open-telemetry/opentelemetry-java/blob/227580ba0956fcd43429d684b7e0798c8723481a/opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanShim.java#L166-L188opentelemetry-dotnet
also does not canonicalize the key: https://github.com/open-telemetry/opentelemetry-dotnet/blob/0889e8dc32badbb4c9be8fd24a974fb7e61fa779/src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs#L140-L144There aren't any references to canonicalizing in spec: https://opentelemetry.io/docs/specs/otel/compatibility/opentracing/#set-baggage-item
Environment
Steps To Reproduce
Test from #4776
https://github.com/scorpionknifes/opentelemetry-go/blob/a112d3f67926fe27a2948a8b15380d5c5ccdcbe1/bridge/opentracing/bridge_test.go#L603-L614
Expected behavior
The baggage item key should be the same.
The text was updated successfully, but these errors were encountered: