Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ensureAttributesCapacity with slices.Grow #4819

Closed
pellared opened this issue Jan 10, 2024 · 3 comments · Fixed by #4967
Closed

Replace ensureAttributesCapacity with slices.Grow #4819

pellared opened this issue Jan 10, 2024 · 3 comments · Fixed by #4967
Labels
enhancement New feature or request
Milestone

Comments

@pellared
Copy link
Member

Replace ensureAttributesCapacity with slices.Grow once we drop support for Go 1.20.

How about inlining the slices.Grow implementation instead of referencing golang.org/x/exp?

Originally posted by @pellared in #4818 (comment)

@pellared pellared added the enhancement New feature or request label Jan 10, 2024
@lizthegrey
Copy link
Member

You also will, while you're in the same code, also want to change the if x > y { foo(x) } else { foo(y) } added in #4818 to a min() per go1.21.

@sumit1606
Copy link

@pellared Mind if I take a stab at it ?

@lizthegrey
Copy link
Member

@pellared Mind if I take a stab at it ?

go1.22 is not yet out, so go1.20 is still supported. Feel free to prepare, but do not land, a PR that does the cleanup I suggested.

@MrAlias MrAlias added this to the v1.25.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants