We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ensureAttributesCapacity with slices.Grow once we drop support for Go 1.20.
How about inlining the slices.Grow implementation instead of referencing golang.org/x/exp?
slices.Grow
golang.org/x/exp
Originally posted by @pellared in #4818 (comment)
The text was updated successfully, but these errors were encountered:
You also will, while you're in the same code, also want to change the if x > y { foo(x) } else { foo(y) } added in #4818 to a min() per go1.21.
if x > y { foo(x) } else { foo(y) }
min()
Sorry, something went wrong.
@pellared Mind if I take a stab at it ?
go1.22 is not yet out, so go1.20 is still supported. Feel free to prepare, but do not land, a PR that does the cleanup I suggested.
Successfully merging a pull request may close this issue.
Replace ensureAttributesCapacity with slices.Grow once we drop support for Go 1.20.
Originally posted by @pellared in #4818 (comment)
The text was updated successfully, but these errors were encountered: