Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to the grpctrace package #684

Closed
MrAlias opened this issue Apr 30, 2020 · 2 comments · Fixed by #695
Closed

Add tests to the grpctrace package #684

MrAlias opened this issue Apr 30, 2020 · 2 comments · Fixed by #695
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
untracked

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 30, 2020

We'll need to be sure to add the tests to cover the failure case identified in #682
@MrAlias MrAlias added enhancement New feature or request good first issue Good for newcomers labels Apr 30, 2020
@MrAlias MrAlias mentioned this issue Apr 30, 2020
Merged
@mujtaba-ahmed12
Copy link
Contributor

I am picking up this as first task.

@htdvisser htdvisser mentioned this issue May 1, 2020
Closed
@stefanprisca
Copy link
Contributor

Added some tests for #682 in PR #683 . Maybe we can merge them together into these :)

@mujtaba-ahmed12 mujtaba-ahmed12 mentioned this issue May 2, 2020
Merged
@MrAlias MrAlias linked a pull request May 14, 2020 that will close this issue
Added test for grpc UnaryInterceptorClient #695
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Added test for grpc UnaryInterceptorClient mujtaba-ahmed12/opentelemetry-go
4 participants
@stefanprisca @pellared @MrAlias @mujtaba-ahmed12