-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep only two routers in filelog #819
Labels
chart:collector
Issue related to opentelemetry-collector helm chart
enhancement
New feature or request
Comments
I can work on this one as I'm working on the attached issue |
I like this, this would simplify the config a bit :) |
TylerHelmuth
added
enhancement
New feature or request
chart:collector
Issue related to opentelemetry-collector helm chart
labels
Jun 30, 2023
Is this a non-breaking change? |
yes, I believe. |
maybe I can roll out a PR and you guy can have a look? |
Sure. I'm most interested in ensuring that the data the the 2 separate routers were intending to capture really can be capture by the same router. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chart:collector
Issue related to opentelemetry-collector helm chart
enhancement
New feature or request
The CRI-O and contained logs are similar,
<timestamp> <stdout|stderr> <logtag> <log message>
The timestamp is of the
rfc3339Nano
specification. The PR signalfx/splunk-otel-collector-chart#817 has updated the timestamp torfc3339Nano
.I think we can keep two routers only:
One for docker
One for cri-o/containerd
We can use the existing cri-o parser. It covers both, Zulu timestamps and timestamps with timezone info.
Related issue: signalfx/splunk-otel-collector-chart#829
The text was updated successfully, but these errors were encountered: