Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only two routers in filelog #819

Open
VihasMakwana opened this issue Jun 27, 2023 · 6 comments
Open

Keep only two routers in filelog #819

VihasMakwana opened this issue Jun 27, 2023 · 6 comments
Labels
chart:collector Issue related to opentelemetry-collector helm chart enhancement New feature or request

Comments

@VihasMakwana
Copy link

The CRI-O and contained logs are similar,
<timestamp> <stdout|stderr> <logtag> <log message>

The timestamp is of the rfc3339Nano specification. The PR signalfx/splunk-otel-collector-chart#817 has updated the timestamp to rfc3339Nano.
I think we can keep two routers only:

One for docker
One for cri-o/containerd

We can use the existing cri-o parser. It covers both, Zulu timestamps and timestamps with timezone info.

Related issue: signalfx/splunk-otel-collector-chart#829

@VihasMakwana
Copy link
Author

I can work on this one as I'm working on the attached issue

@povilasv
Copy link
Contributor

I like this, this would simplify the config a bit :)

@TylerHelmuth TylerHelmuth added enhancement New feature or request chart:collector Issue related to opentelemetry-collector helm chart labels Jun 30, 2023
@TylerHelmuth
Copy link
Member

Is this a non-breaking change?

@VihasMakwana
Copy link
Author

yes, I believe.

@VihasMakwana
Copy link
Author

maybe I can roll out a PR and you guy can have a look?

@TylerHelmuth
Copy link
Member

Sure. I'm most interested in ensuring that the data the the 2 separate routers were intending to capture really can be capture by the same router.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:collector Issue related to opentelemetry-collector helm chart enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants