Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "retry_on_failure" setting to filelog #822

Closed
djaglowski opened this issue Jun 28, 2023 · 4 comments
Closed

Add "retry_on_failure" setting to filelog #822

djaglowski opened this issue Jun 28, 2023 · 4 comments
Assignees
Labels
chart:collector Issue related to opentelemetry-collector helm chart enhancement New feature or request good first issue Good for newcomers

Comments

@djaglowski
Copy link
Member

User reports seeing the following error when using the logsCollection preset.

2023-06-27T20:26:11.105Z error consumerretry/logs.go:39 ConsumeLogs() failed. Enable retry_on_failure to slow down reading logs and avoid dropping. {"kind": "receiver", "name": "filelog", "data_type": "logs", "error": "data refused due to high memory usage"}

Likely the problem is that the filelog receiver is ingesting data at a faster rate than the collector can export. A new retry_on_failure configuration was recently added, which allows the the receiver to respond to backpressure by blocking ingesting until data is successfully consumed by the next component.

Additional context: https://cloud-native.slack.com/archives/C01N5UCHTEH/p1687898643893809

@TylerHelmuth
Copy link
Member

Seems like a good idea. @djaglowski is the best practice to enable this feature by default?

@TylerHelmuth TylerHelmuth added enhancement New feature or request chart:collector Issue related to opentelemetry-collector helm chart labels Jun 28, 2023
@djaglowski
Copy link
Member Author

Seems like a good idea. @djaglowski is the best practice to enable this feature by default?

@dmitryax may be better suited to answer this but I think likely we should.

@dmitryax
Copy link
Member

Yes, I think we should enable it by default.

@TylerHelmuth TylerHelmuth added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 28, 2023
@husnialhamdani
Copy link
Member

Hi, Can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart:collector Issue related to opentelemetry-collector helm chart enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants