Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Jetty 12 #10387

Closed
zeitlinger opened this issue Feb 2, 2024 · 4 comments · Fixed by #10575
Closed

Add support Jetty 12 #10387

zeitlinger opened this issue Feb 2, 2024 · 4 comments · Fixed by #10575
Assignees
Labels

Comments

@zeitlinger
Copy link
Member

zeitlinger commented Feb 2, 2024

Spring Boot 3.2 uses Jetty 12 - to get full jetty support.

@zeitlinger zeitlinger converted this from a draft issue Feb 2, 2024
@zeitlinger zeitlinger added spring boot starter enhancement New feature or request labels Feb 2, 2024
@zeitlinger zeitlinger self-assigned this Feb 2, 2024
@trask
Copy link
Member

trask commented Feb 2, 2024

otherwise you don't get any server spans

I thought the servlet instrumentation would create the server span if the app server specific instrumentation didn't already?

@zeitlinger
Copy link
Member Author

otherwise you don't get any server spans

I thought the servlet instrumentation would create the server span if the app server specific instrumentation didn't already?

No, apparently that doesn't happen - I've checked that in a test

@breedx-splk
Copy link
Contributor

otherwise you don't get any server spans

I thought the servlet instrumentation would create the server span if the app server specific instrumentation didn't already?

No, apparently that doesn't happen - I've checked that in a test

I'm also surprised by this result, and while yes sure, we should support the latest Jetty, I think it would be helpful to understand why the servlet instrumentation didn't kick in.

@zeitlinger
Copy link
Member Author

Turns out my test was misleading - we get a different server span, rather than no span at all.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants