Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture request and response bodies #1317

Closed
pavolloffay opened this issue Oct 3, 2020 · 2 comments
Closed

Capture request and response bodies #1317

pavolloffay opened this issue Oct 3, 2020 · 2 comments

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Oct 3, 2020

We have a requirement to capture all request and response bodies. Capturing bodies is more complicated bc it requires wrapping read/write streams - so additional configuration. This feature should be disabled by default with no cost for people who don't want to capture any bodies.

The use case is for business transaction monitoring http://trasier.com/ and security.

I will submit a spec issue to define data semantics for request and response bodies.

EDIT: another issue with wrapping #1096

@iNikem
Copy link
Contributor

iNikem commented Oct 5, 2020

Just a friendly warning :) See #726, #1083 and related PRs. We already tried to add wrappers, it ended badly

@trask
Copy link
Member

trask commented Apr 3, 2021

Closing, please re-open once there is semantic convention for request/response bodies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants