You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently our HttpServerTest verifies that the span name for a not found request is the request path. As the request was not actually mapped, there is no route to match it against so this can only be achieved with a high cardinality name using the path directly. I think we usually want to use the method for such cases.
This should only apply to unmapped requests - if a handler accepted it and returned 404 explicitly (e.g. a request with a path param for an Id that didn't exist in the db) it should still use the route.
The text was updated successfully, but these errors were encountered:
Currently our HttpServerTest verifies that the span name for a not found request is the request path. As the request was not actually mapped, there is no route to match it against so this can only be achieved with a high cardinality name using the path directly. I think we usually want to use the method for such cases.
This should only apply to unmapped requests - if a handler accepted it and returned 404 explicitly (e.g. a request with a path param for an Id that didn't exist in the db) it should still use the route.
The text was updated successfully, but these errors were encountered: