Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@WithSpan and customTextMapPropagator #2438

Open
mnadeem opened this issue Feb 28, 2021 · 1 comment
Open

@WithSpan and customTextMapPropagator #2438

mnadeem opened this issue Feb 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mnadeem
Copy link

mnadeem commented Feb 28, 2021

Describe the bug

This is related to #2436

@WithSpan could be more robust if there is a way to specify custom Propagator to extract parent trace.

image

Even though there is parent trace a new trace is created.

image

This limits the use of @WithSpan, if a library is not instrumented. And we would be forced to create span the hard way.

Steps to reproduce
use this project : https://github.com/mnadeem/boot-opentelemetry-tempo

What did you expect to see?

A easy and custom way for @WithSpan to extract parent trace, if a library is not instrumented.

What did you see instead?
A clear and concise description of what you saw instead.

What version are you using?
(e.g., v0.9.0, 393e4a2, etc)

Environment
Compiler: (e.g., "AdoptOpenJDK 11.0.6")
OS: (e.g., "Ubuntu 20.04")
Runtime (if different from JDK above): (e.g., "Oracle JRE 8u251")
OS (if different from OS compiled on): (e.g., "Windows Server 2019")

Additional context
Add any other context about the problem here.

@mnadeem mnadeem added the bug Something isn't working label Feb 28, 2021
@trask trask added enhancement New feature or request and removed bug Something isn't working labels Aug 25, 2021
@trask
Copy link
Member

trask commented Aug 26, 2023

cc @zeitlinger @jack-berg related to SIG discussion about open-telemetry/opentelemetry-java-contrib#759 and a convenience API for interacting with propagators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants