Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service suppression for gRPC #2806

Closed
johnerikhalse opened this issue Apr 14, 2021 · 2 comments
Closed

Service suppression for gRPC #2806

johnerikhalse opened this issue Apr 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@johnerikhalse
Copy link

Is your feature request related to a problem? Please describe.
While it is possible to suppress traces based on classes and methods, I couldn't find a way to suppress traces from specific gRPC services.

I have services implementing an API which I want traces from, but in addition I have a health checker service which adds a lot of spans which in this context is noise.

Describe the solution you'd like
I would like to have a way to configure which services should or should not be traced. One way of doing this could be to suppress spans based on span name. This way it would not only apply to gRPC services. For example one might wan't some important db calls to be traced while suppressing others.

From a users perspective options similar to the properties for include/exclude of @WithSpan, but accepting wildcards, would be ideal. I don't know what impact this might have on performance though.

@johnerikhalse johnerikhalse added the enhancement New feature or request label Apr 14, 2021
@trask
Copy link
Member

trask commented Apr 14, 2021

Hey @johnerikhalse! I think you are looking for this feature: #1060, which hasn't been implemented yet.

@johnerikhalse
Copy link
Author

I think you are right. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants