Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratpack/netty https bug in Agents >= 1.0.1 #3195

Closed
necrolyte2 opened this issue Jun 4, 2021 · 0 comments · Fixed by #3228
Closed

ratpack/netty https bug in Agents >= 1.0.1 #3195

necrolyte2 opened this issue Jun 4, 2021 · 0 comments · Fixed by #3228
Labels
bug Something isn't working repro provided

Comments

@necrolyte2
Copy link

Describe the bug
It appears that https connections are generating a connection error span for https connections in some circumstances, and then generating a separate span for the actual https request

I've tried both the 1.2.0 agent and the 1.0.1 agent and both behave the same for this bug from what I can see.
The 0.17.0 agent does not have this issue though.

Steps to reproduce
Run the example repo
Hit the following url
http://localhost:5050/api/v1/1
View spans in the local jaeger UI

What did you expect to see?
There should be no errors reported and the /api/v1/:id operation should have 7 spans nested under it
Screen Shot 2021-06-04 at 5 01 03 PM

What did you see instead?
http requests are correctly nested under the trace, however, any https connection is missing and instead a single connect error span is emitted in their place

Screen Shot 2021-06-04 at 4 57 15 PM
Screen Shot 2021-06-04 at 4 59 15 PM

What version are you using?
OTEL Agent 1.2.0
OTEL Agent 1.0.1

Environment
Compiler: "AdoptOpenJDK 11.0.6"
OS: Mac OS

Additional context
This may or may not be related to the issue in #2748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repro provided
Projects
None yet
2 participants