Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review RabbitMQ instrumentation's semantic conventions usage #3337

Closed
mateuszrzeszutek opened this issue Jun 16, 2021 · 3 comments · Fixed by #3425
Closed

Review RabbitMQ instrumentation's semantic conventions usage #3337

mateuszrzeszutek opened this issue Jun 16, 2021 · 3 comments · Fixed by #3425
Labels
bug Something isn't working

Comments

@mateuszrzeszutek
Copy link
Member

RabbitMQ does not seem to implement messaging semantic conventions correctly, e.g. it uses testTopic -> testTopic send instead of testTopic send as span names.

Additional context
#3295 (comment)

@RashmiRam
Copy link
Contributor

The Producer span names are also not complying with semantic conventions.

Producer Span names are getting generated as ["<exchange> -> <routing key> send"] as per this code here. Cardinality of the routing key can be huge based on individual's use cases.

Spec also says that it should be <message.destination> <operation name>. message.destination for RabbitMQ producer span is exchange name only.

Shouldn't this just be "<exchange> send" similar to how Kafka instrument works?

@RashmiRam
Copy link
Contributor

@mateuszrzeszutek If it's alright, Shall I raise a PR to fix this one?

@mateuszrzeszutek
Copy link
Member Author

Sure, that'd be great help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants