Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make attributes such as http.url available before a span is started #388

Closed
patsonluk opened this issue May 6, 2020 · 0 comments · Fixed by #2587
Closed

Make attributes such as http.url available before a span is started #388

patsonluk opened this issue May 6, 2020 · 0 comments · Fixed by #2587
Assignees
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome

Comments

@patsonluk
Copy link

Hi, we run into similar issue as #230 and wish to know the URL when doing sampling decision.

But it seems like with the change in https://github.com/open-telemetry/opentelemetry-auto-instr-java/pull/348/files , the http.url is still not available for example in the Servlet3Advice, the DECORATOR which adds the http.url attribute is not run until the span is started.

Wondering if it's feasible to change the DECORATOR to allow a beforeSpanStart or even change the onRequest and onConnection to take SpanBuilder and have them executed before the span is started?

Many thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants