-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share code and tests with contrib instrumentation #45
Comments
Linking in #195 |
If there's agreement on the direction for this issue, I could help do some moving. Perhaps I could start by moving the decorators into |
Hi @anuraaga, help on this would be great! I think it will be easier to share code and tests between auto and manual instrumentation if they are in the same repo, at least short-term while we are figuring out how to share. Have a look at #195. I think the first step is to take one of the simpler instrumentations, and extract out the generic bits using that model. You'll end up with 3 modules: one module with the generic parts, one module with the manual instrumentation, and (the existing) module with the auto-instrumentation that now depends on the module with the generic parts. We definitely want to share tests between manual and auto-instrumentation as well, so that's another challenge to work through with this first instrumentation. |
Closing this now, good progress is being made on this in several other issues and PRs. And this issue has outlived its usefulness. |
Some things we could probably share with contrib instrumentation:
The text was updated successfully, but these errors were encountered: