Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Http4SpanDecorator to apache-camel-2.20 instrumetation #4644

Closed
osherv opened this issue Nov 15, 2021 · 2 comments
Closed

Add Http4SpanDecorator to apache-camel-2.20 instrumetation #4644

osherv opened this issue Nov 15, 2021 · 2 comments
Assignees
@osherv
Labels
enhancement New feature or request

Comments

@osherv
Copy link
Member

osherv commented Nov 15, 2021 •
edited
Loading

Today, the handling for http4 requests is the default HttpSpanDecorator.
In this behavior, the captured http.url could be "http4:/url" which is incorrect.

I'd like to add a new Http4SpanDecorator that inherits from HttpSpanDecorator and overrides HttpSpanDecorator::getHttpUrl
and will return the real URL.

I already have the module decorator that could fix that, pls assign this issue to me and i'll open pr :)
Thanks.
@osherv osherv added the enhancement New feature or request label Nov 15, 2021
@osherv osherv changed the title Add Http4SpanDecorator to apache-camel-2.20 instruemtation Add Http4SpanDecorator to apache-camel-2.20 instrumetation Nov 15, 2021
@mateuszrzeszutek
Copy link
Member

Please go ahead, I've assigned you.
Thanks!

@laurit
Copy link
Contributor

laurit commented Dec 22, 2021

Resolved with #4650

@laurit laurit closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osherv osherv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laurit @mateuszrzeszutek @osherv