Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When implement RPC metrics #4747

Closed
yangtaoran opened this issue Nov 30, 2021 · 2 comments
Closed

When implement RPC metrics #4747

yangtaoran opened this issue Nov 30, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@yangtaoran
Copy link
Contributor

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/rpc.md, here, I find the specification had definded the RPC metrics, but the java-instrumentation not implement it.
So, I hope we can discuss the feature that how to complete it.

@yangtaoran yangtaoran added the enhancement New feature or request label Nov 30, 2021
@trask
Copy link
Member

trask commented Dec 1, 2021

hi @yangtaoran! if you are interested in implementing this, a good starting place is to check out how HttpServerMetrics and HttpClientMetrics are implemented.

@yangtaoran
Copy link
Contributor Author

done #4838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants