Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Service Name from Spring Boot application properties #5414

Closed
mkrzywanski opened this issue Feb 19, 2022 · 3 comments
Closed

Setting Service Name from Spring Boot application properties #5414

mkrzywanski opened this issue Feb 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@mkrzywanski
Copy link

Is your feature request related to a problem? Please describe.
I would like to set service name from Spring Boot properties so that when the spans are sent to Jaeger the service name matches the actual spring boot service name and is not unknown. As far as I can see Spring Boot autoconfiguration in spring-boot-autoconfigure module does not give any opportunity to set ResourceAttributes.SERVICE_NAME. If it is possbile to set it somehow with current implementation I would be glad to know the way. If not I would be happy to maybe contribute it.

@mkrzywanski mkrzywanski added the enhancement New feature or request label Feb 19, 2022
@mkrzywanski mkrzywanski changed the title Setting Service Name from Spring Boot application Setting Service Name from Spring Boot application properties Feb 20, 2022
@aschugunov
Copy link
Contributor

aschugunov commented Feb 24, 2022

hey @mkrzywanski it looks similar to 3480
I made PR with the same idea

@mkrzywanski
Copy link
Author

Any update on this? I can see two PRs concerning same issue and noone wants to review them. Right now this autoconfiguration is pretty unusable if I cannot set values for Resource and I have to create sdkTracer bean myself.

@mateuszrzeszutek
Copy link
Member

Implemented in #5359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants