Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception transforming javaagent class #5499

Closed
anuraaga opened this issue Mar 4, 2022 · 3 comments · Fixed by #5528
Closed

Exception transforming javaagent class #5499

anuraaga opened this issue Mar 4, 2022 · 3 comments · Fixed by #5528
Labels
bug Something isn't working

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Mar 4, 2022

While debugging a customer issue, I found this debug logging. Is this expected / harmless?

[otel.javaagent 2022-03-03 20:08:36:330 +0000] [AD Thread Pool-Global1] DEBUG io.opentelemetry.javaagent.tooling.AgentInstaller$TransformLoggingListener - Failed to handle io.opentelemetry.javaagent.instrumentation.servlet.AsyncRunnableWrapper for transformation on classloader java.net.URLClassLoader@2f4e40d7
net.bytebuddy.pool.TypePool$Resolution$NoSuchTypeException: Cannot resolve type description for io.opentelemetry.javaagent.instrumentation.servlet.ServletHelper
@anuraaga anuraaga added the bug Something isn't working label Mar 4, 2022
@mateuszrzeszutek
Copy link
Member

Hmm, why would AsyncRunnableWrapper even get transformed? It's an injected helper class, I thought we were explicitly skipping these.

@anuraaga
Copy link
Contributor Author

anuraaga commented Mar 4, 2022

@mateuszrzeszutek Exactly why this line stood out more than other type description errors :)

@laurit
Copy link
Contributor

laurit commented Mar 4, 2022

@anuraaga could you add stack trace. Maybe seeing where this class is defined from helps to understand why this happens. As far as I know we don't explicitly exclude injected classes from transformation but rely on classes defined while transforming a class not triggering a nested transform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants