Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async cancellation should use same attribute name #5765

Closed
anuraaga opened this issue Apr 7, 2022 · 2 comments
Closed

async cancellation should use same attribute name #5765

anuraaga opened this issue Apr 7, 2022 · 2 comments
Labels
blocked on specification Needs specification work before this can be resolved enhancement New feature or request

Comments

@anuraaga
Copy link
Contributor

anuraaga commented Apr 7, 2022

Currently the attribute name when canceling an async return value via WithSpan encodes the instrumentation name as well

guava.canceled
reactor.canceled

I would expect them all to be the same. Though it's true that because the async end strategy is not the instrumentation name (which is otelannotations), it would lose that information.

@anuraaga anuraaga added the bug Something isn't working label Apr 7, 2022
@trask
Copy link
Member

trask commented Apr 19, 2022

some ideas:

  • future.canceled
  • promise.canceled
  • async.canceled

I don't love async.canceled because async has such a broad meaning. I think my vote currently would go toward promise.canceled.

@trask trask added enhancement New feature or request blocked on specification Needs specification work before this can be resolved and removed bug Something isn't working labels Sep 4, 2023
@trask
Copy link
Member

trask commented Dec 22, 2024

Closing, these attributes are now opt-in under an experimental flag, can revisit later if anyone has renewed interest.

@trask trask closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked on specification Needs specification work before this can be resolved enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants