Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export jaeger-thrift over UDP #5821

Closed
noahseger opened this issue Apr 13, 2022 · 2 comments
Closed

Export jaeger-thrift over UDP #5821

noahseger opened this issue Apr 13, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@noahseger
Copy link

noahseger commented Apr 13, 2022

Is your feature request related to a problem? Please describe.

After the discussion in #1973, jaeger-thrift exporter support was dropped. However, in Jaeger Agent deployments, Agents are designed to only accept thrift over UDP. This means that users need to write custom exporters to get traces into Jaeger, or trade off the backpressure provided by the agent-based deployment approach.

Describe the solution you'd like

Support the UDP-based Jaeger strategy as a first-class exporter.

Describe alternatives you've considered

If it is not a priority for the team, consider documenting that UDP exporting is not supported.

Additional context

Latest documentation of stable protocols https://www.jaegertracing.io/docs/1.33/apis/.

I also found this issue in the PHP library so it may be helpful for them to be able to follow a backlink from there to any discussion here open-telemetry/opentelemetry-php#296.

@noahseger noahseger added the enhancement New feature or request label Apr 13, 2022
@anuraaga
Copy link
Contributor

We would probably need to rewrite the thrift exporter to remove dependencies on the Thrift library and autogenerated code, similar to what we did for gRPC / protobuf, to include the exporter by default in the javaagent. Is this something you would be able to help with?

Otherwise, perhaps we could publish a packaged extension jar to be able to provide on the command line more easily though as a middle ground.

For context, I suppose that in general we hope that users can switch from the jaeger agent to the opentelemetry collector with its jaeger exporter - is this something you looked into?

@mateuszrzeszutek
Copy link
Member

Jaeger exporters have been deprecated; which means we won't be adding any new Jaeger export options.

@mateuszrzeszutek mateuszrzeszutek closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants