New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ServerSpan to LocalRootSpan? #5857

Closed

trask opened this issue Apr 17, 2022 · 0 comments · Fixed by #5896

Assignees

Member

trask commented Apr 17, 2022 •

edited

Loading

I haven't thought through this but wanted to write it down as we approach instrumentation-api stability.

E.g. a common use case is to tag attributes on the local root, and LocalRoot would cover SERVER, CONSUMER, and "scheduled jobs" INTERNAL spans

trask changed the title ~~Rename ServerSpan to LocalRoot?~~ Rename ServerSpan to LocalRootSpan?

trask mentioned this issue

Enable span suppression by SpanKey by default #5779

Merged

mateuszrzeszutek self-assigned this

mateuszrzeszutek mentioned this issue

Introduce LocalRootSpan (replacing ServerSpan) #5896

Merged

mateuszrzeszutek closed this as completed in #5896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment