Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgentTracerProviderConfigurer#loggingExporterIsNotAlreadyConfigured #5927

Closed
chenjazz opened this issue Apr 24, 2022 · 3 comments · Fixed by #5928
Closed

AgentTracerProviderConfigurer#loggingExporterIsNotAlreadyConfigured #5927

chenjazz opened this issue Apr 24, 2022 · 3 comments · Fixed by #5928
Labels
bug Something isn't working

Comments

@chenjazz
Copy link

  private static boolean loggingExporterIsNotAlreadyConfigured() {
    return !Config.get().getString("otel.traces.exporter", "").equalsIgnoreCase("logging");
  }

Mybe otel.traces.exporter has serveral values,like otel.traces.exporter=otlp,logging

@chenjazz chenjazz added the bug Something isn't working label Apr 24, 2022
@wallezhang
Copy link
Contributor

wallezhang commented Apr 25, 2022

I think it should use getList() method instead of getString() method and use contains() method to determine whether the logging exporter has been configured.

I will fix it. Thanks for report.

@trask
Copy link
Member

trask commented Apr 25, 2022

hi @chenjazz @wallezhang! I thought that otel.traces.exporter doesn't support multiple values?

@wallezhang
Copy link
Contributor

hi @chenjazz @wallezhang! I thought that otel.traces.exporter doesn't support multiple values?

According to this document: https://github.com/open-telemetry/opentelemetry-java/tree/main/sdk-extensions/autoconfigure#exporters

The configuration support multiple values that separated by commas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants