Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime.jvm.gc.count metric reports invalid unit "collections" #6929

Closed
PeterF778 opened this issue Oct 20, 2022 · 4 comments
Closed

runtime.jvm.gc.count metric reports invalid unit "collections" #6929

PeterF778 opened this issue Oct 20, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@PeterF778
Copy link
Contributor

PeterF778 commented Oct 20, 2022

Describe the bug
Garbage Collection metric runtime.jvm.gc.count reports the unit as "collections", which is an invalid unit.

Steps to reproduce
Enable GC metrics by specifying -Dotel.instrumentation.runtime-metrics.experimental-metrics.enabled=true on the java command line with the agent. Watch the metric data stream for "runtime.jvm.gc.count".

What did you expect to see?
A correct unit can be "{collections}", or "1{collections}", or just "1".

What did you see instead?
The reported unit comes out as "collections".

What version are you using?
1.18

Environment

Additional context
Add any other context about the problem here.

@PeterF778 PeterF778 added the bug Something isn't working label Oct 20, 2022
@trask
Copy link
Member

trask commented Oct 20, 2022

thanks for reporting this! it looks like we made this mistake in several places, I can send a PR to fix if you aren't working on it already

@PeterF778
Copy link
Contributor Author

Please go ahead or assign to me, whatever you prefer.

@trask
Copy link
Member

trask commented Oct 20, 2022

assigning you, thx ❤️

@trask
Copy link
Member

trask commented Oct 21, 2022

Closed by #6930

@trask trask closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants