Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent way to set service.name for OTLP, Jaeger and Zipkin exporters? #703

Closed
trask opened this issue Jul 15, 2020 · 2 comments
Closed

Comments

@trask
Copy link
Member

trask commented Jul 15, 2020

From #424 (comment):

The current way to set service.name is a little disjointed:

For OTLP exporter:

export OTEL_RESOURCE_ATTRIBUTES=service.name=shopping

For Jaeger exporter:

-Dota.exporter.jaeger.service.name=shopping

For Zipkin exporter:

-Dota.exporter.zipkin.service.name=shopping

This may also require discussion/changes in opentelemetry-java.

@tedsuo
Copy link

tedsuo commented Jul 15, 2020

This may be broader than just service names, since arbitrary resources need to be supported by all exporters. This is easy for OTLP, but confusing for Jaeger and Zipkin, which may or may not have equivalent concepts (I admit ignorance on this one).

In addition to not supporting arbitrary resources, these formats may have native concepts which map to specific resources. service.name is mentioned here, but there may be more. If a user sets one of these special resources, we want to map it to the equivalent concept in zipkin or jaeger. For arbitrary resources, we want a standard transformation (for example, turning resources into span attributes).

Since this relates to data protocols, it is a cross-language issue and should be defined in the spec.

Resource transformations for Zipkin need to be added here: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/zipkin.md#opentelemetry-to-zipkin-transformation

Jaeger transformations need to be added in general: open-telemetry/opentelemetry-specification#414

@trask
Copy link
Member Author

trask commented Jul 16, 2020

Thanks @tedsuo.

I'm going to close this, it looks like this discussion is already in the works in the specification repo (open-telemetry/opentelemetry-specification#666).

In particular, that PR only specifies OTEL_RESOURCE_ATTRIBUTES for setting service name across OTLP, Jaeger and Zipkin exporters.

Plus there's a proposal for a simpler way to set the service name (which sounds really helpful @anuraaga) open-telemetry/opentelemetry-specification#666 (comment).

@trask trask closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants