Skip to content

Commit 27edbd8

Browse files
EcsResource: Record log group without trailing :*
Both with and without trailing `:*` are valid formats but there is a bug in the OpenTelementry collector which can’t handle the trailing `:*` (for now) (see open-telemetry/opentelemetry-collector-contrib#13702) So remove addition of the trailing `:*` for now.
1 parent 57cd334 commit 27edbd8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

sdk-extensions/aws/src/main/java/io/opentelemetry/sdk/extension/aws/resource/EcsResource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ Optional<String> getLogGroupArn() {
203203
}
204204

205205
return Optional.of(
206-
"arn:aws:logs:" + region + ":" + account + ":log-group:" + logGroupName + ":*");
206+
"arn:aws:logs:" + region + ":" + account + ":log-group:" + logGroupName);
207207
}
208208

209209
Optional<String> getLogStreamArn() {

sdk-extensions/aws/src/test/java/io/opentelemetry/sdk/extension/aws/resource/EcsResourceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ void testCreateAttributesV4() throws IOException {
104104
entry(
105105
ResourceAttributes.AWS_LOG_GROUP_ARNS,
106106
Collections.singletonList(
107-
"arn:aws:logs:us-west-2:111122223333:log-group:/ecs/metadata:*")),
107+
"arn:aws:logs:us-west-2:111122223333:log-group:/ecs/metadata")),
108108
entry(
109109
ResourceAttributes.AWS_LOG_STREAM_NAMES,
110110
Collections.singletonList("ecs/curl/8f03e41243824aea923aca126495f665")),

0 commit comments

Comments
 (0)