-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource sdk.version support #1311
Comments
I'm happy to implement this if there's agreement on a general approach. Mainly found this to make sure that I was worried I might squash it. Given the |
Slightly related, one of the main arguments for #1058 is currently that it is currently very hard to explicitly set a resource that is used by the global TracerSdkProvider. |
@Oberon00 I would suggest probably to add a |
Also I think the initial issue was about the SDK automatically adding the library version to the resource, which we should do anyway. |
Yeah sorry for possible noise - it was about automatically adding the library version, but in a way that doesn't clobber with user-configured resources. The latter actually seems pretty tricky :) |
Sounds great to me. +1 for some default values on start time. |
Is your feature request related to a problem? Please describe.
Let me know if I'm missing it but I don't think the SDK fills in information about itself as described here
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resource/semantic_conventions/README.md#telemetry-sdk
Describe the solution you'd like
The SDK should fill in the SDK attributes. It'll probably need to propagate the current version into a Java resource file.
One thing that comes to mind is it seems to warrant exposing SDK resource attributes. Users may want to add custom attributes like here
https://github.com/aws-samples/aws-xray-sdk-with-opentelemetry-sample/blob/both-otel-and-xray/awsagentprovider/src/main/java/com/softwareaws/xray/opentelemetry/exporters/AwsTraceProvider.java#L40
And this would need some way to access the SDK resource so it can augment it, rather than replace it completely.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: