Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move protos to opentelemetry-proto repo. #235

Closed
bogdandrutu opened this issue May 1, 2019 · 5 comments
Closed

Move protos to opentelemetry-proto repo. #235

bogdandrutu opened this issue May 1, 2019 · 5 comments

Comments

@bogdandrutu
Copy link
Member

No description provided.

@kaushikchaubal
Copy link

Looks like changes for this was merged, right? Is it worth closing the issue?

@pavolloffay
Copy link
Member

The protos have been copied but they are still here https://github.com/open-telemetry/opentelemetry-java/tree/master/sdk/src/main/proto. Maybe it would be better to consume them as a git submodule.

@kaushikchaubal
Copy link

Do you want me to create a git submodule for https://github.com/open-telemetry/opentelemetry-java/tree/master/sdk/src/main/proto then? If so, I can aim to create a PR for that.

@pavolloffay
Copy link
Member

Let's see what others say, I think it's a good idea.

@songy23
Copy link
Member

songy23 commented Jun 7, 2019

+1 to git submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants