Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was the annotation @WithSpan moved out #4877

Closed
Emily-Jiang opened this issue Oct 20, 2022 · 2 comments
Closed

Why was the annotation @WithSpan moved out #4877

Emily-Jiang opened this issue Oct 20, 2022 · 2 comments

Comments

@Emily-Jiang
Copy link

I just noticed in the release 1.19, the annotation WithSpan the SpanAttribute was moved to another project, which is in alpha state. I have a few concerns:

  1. Why was the reason of moving these annotationed moved to java-instrumentation? I looked at the issue 6245, but I did not find out why.
  2. Are the annoations stable since they were moved to a unstable project [opentelemetry-java-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation)
  3. This move is a breaking change. Should this happen in a minor release.
@trask
Copy link
Member

trask commented Oct 21, 2022

hi @Emily-Jiang!

the main reason the annotations were moved to the instrumentation repo is so that they can evolve alongside the instrumentation code, as we found ourselves at a roadblock in #4260

opentelemetry-java-instrumentation is not inherently unstable, though the new annotation artifact in the instrumentation repository is currently marked unstable. we have an issue tracking making the new annotation artifact stable: open-telemetry/opentelemetry-java-instrumentation#6494, if you can comment over there it could help move that along

whether this move is a breaking change was discussed over a couple of SIG meetings, and the consensus is summarized in #4729

@jack-berg
Copy link
Member

I'm going to close this issue. Please feel free to re-open if more information is needed on the stability guarantees!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants