Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to let trace exporter to export all the spans to OTel agent/collector regardless of the sampled flag in the spans' are 0/1 and let OTel agent/collector to make the decision based on the spans' sampled flag? #4990

Open
wdengw opened this issue Nov 26, 2022 · 3 comments
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project

Comments

@wdengw
Copy link

wdengw commented Nov 26, 2022

Is your feature request related to a problem? Please describe.
Is there a way to let trace exporter to export all the spans to OTel agent/collector regardless of the sampled flag in the spans' are 0/1 and let OTel agent/collector to make the decision based on the spans' Sampled flag?

Describe the solution you'd like
The SDK allows all spans to be exported to OTel Agent/Collector with its Sampled flag, so that The OTel agent/collector can receive 100% of the spans created by the app. This opens the opportunity for OTel Agent/Collector's processors opportunity to gather information from all spans and it can decided to store the spans to backend store based the spans' sampled flag.

Describe alternatives you've considered

Additional context
In SdkSpanBuilder.startSpan() PropagatedSpan is created when Span is not sampled, resulting in the span not being exported.

Also, OTel's trace.proto don't have fields to pass the sample flag to OTel agent/collector.

@wdengw wdengw added the Feature Request Suggest an idea for this project label Nov 26, 2022
@wdengw wdengw changed the title Is there a way to let trace exporter to export all the spans to OTel agent/collector regardless of the sampled flag in the spans' are 0/1 and let OTel agent/collector to make the decision based on the spans' Sampled flag? Is there a way to let trace exporter to export all the spans to OTel agent/collector regardless of the sampled flag in the spans' are 0/1 and let OTel agent/collector to make the decision based on the spans' sampled flag? Nov 26, 2022
@jkwatson
Copy link
Contributor

This would need to be added to the specification if we were to implement it in Java. Please raise this as an issue in the specification repository. Thanks!

@wdengw
Copy link
Author

wdengw commented Nov 26, 2022

@jkwatson FYI, open-telemetry/opentelemetry-specification#2986

@jack-berg
Copy link
Member

Related to #4467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked:spec blocked on open or unresolved spec Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

3 participants