-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mysql): set proper context for outgoing queries #1140
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
- Coverage 96.07% 95.97% -0.11%
==========================================
Files 14 17 +3
Lines 892 1093 +201
Branches 191 221 +30
==========================================
+ Hits 857 1049 +192
- Misses 35 44 +9
|
Can you add a test for it? |
Done, not sure if there is a better way to do it instead of stubbing a private method used in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Golden, other than the two nits.
Set the proper context for outgoing mysql queries so
net
and possiblydns
instrumentation spans are linked correctly.