Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql): set proper context for outgoing queries #1140

Merged
merged 13 commits into from
Sep 13, 2022

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Aug 31, 2022

Set the proper context for outgoing mysql queries so net and possibly dns instrumentation spans are linked correctly.

@seemk seemk requested a review from a team August 31, 2022 11:18
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1140 (e9aac13) into main (dbf37fb) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
- Coverage   96.07%   95.97%   -0.11%     
==========================================
  Files          14       17       +3     
  Lines         892     1093     +201     
  Branches      191      221      +30     
==========================================
+ Hits          857     1049     +192     
- Misses         35       44       +9     
Impacted Files Coverage Δ
...metry-instrumentation-mysql/src/instrumentation.ts 93.60% <100.00%> (ø)
...e/opentelemetry-instrumentation-mysql/src/utils.ts 100.00% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 98.00% <0.00%> (ø)

@blumamir blumamir changed the title fix: mysql: set proper context for outgoing queries fix(mysql): set proper context for outgoing queries Aug 31, 2022
@dyladan
Copy link
Member

dyladan commented Aug 31, 2022

Can you add a test for it?

@seemk
Copy link
Contributor Author

seemk commented Sep 1, 2022

Can you add a test for it?

Done, not sure if there is a better way to do it instead of stubbing a private method used in the query function. Suggestions welcome 🙂

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Golden, other than the two nits.

@rauno56 rauno56 merged commit 59f7bce into open-telemetry:main Sep 13, 2022
@dyladan dyladan mentioned this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants